apple
Cherry pick Choose log router tag prior to resolution in commit path for version vector. (#11628)
Cherry pick Choose log router tag prior to resolution in commit path for version vector. (#11628)
Joshua
20240906-183549-dlambrig-8e5736193ea62765
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
- [ ] The PR has a description, explaining both the problem and the solution.
- [ ] The description mentions which forms of testing were done and the testing seems reasonable.
- [ ] Every function/class/actor that was touched is reasonably well documented.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
- [ ] This change/bugfix is a cherry-pick from the next younger branch (younger
release-branchormainif this is the youngest branch) - [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:37:45
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-macos on macOS Ventura 13.x
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:44:38
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-clang-arm on Linux CentOS 7
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:45:21
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-clang on Linux CentOS 7
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:47:40
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:52:50
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
- Cluster Test Logs zip file of the test logs (available for 30 days)
Result of foundationdb-pr on Linux CentOS 7
- Commit ID: b2b5fa37cac271a68b3a903d5f67bccd6e9e5125
- Duration 0:54:09
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:35:45
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:38:55
- Result: :x: FAILED
- Error:
Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8 - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
I think you can go ahead and merge these changes. Maybe you can address the assertion failure in a follow up PR.
Result of foundationdb-pr-clang on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:42:06
- Result: :x: FAILED
- Error:
Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1 - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-macos on macOS Ventura 13.x
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:45:16
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-clang-arm on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:46:48
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
I think you can go ahead and merge these changes. Maybe you can address the assertion failure in a follow up PR.
It will first be fixed in 7.4
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:52:27
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
- Cluster Test Logs zip file of the test logs (available for 30 days)
Result of foundationdb-pr-clang on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 0:51:06
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr on Linux CentOS 7
- Commit ID: d47caa9ee73818cf21afe170f14acf46b112289b
- Duration 1:03:25
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 0:37:57
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-macos on macOS Ventura 13.x
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 0:45:50
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-clang-arm on Linux CentOS 7
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 0:46:02
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 0:52:49
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
- Cluster Test Logs zip file of the test logs (available for 30 days)
Result of foundationdb-pr-clang on Linux CentOS 7
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 1:17:05
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)
Result of foundationdb-pr on Linux CentOS 7
- Commit ID: 440ed450c854cfc4593864fcd377f0c3697d11e3
- Duration 1:17:18
- Result: :white_check_mark: SUCCEEDED
- Error:
N/A - Build Log terminal output (available for 30 days)
- Build Workspace zip file of the working directory (available for 30 days)