foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard
verified publisher icon apple

Fix several issues found by flake8

Open sfc-gh-abeamon opened this issue 2 years ago • 9 comments

This also ignores E402, which detects when we have module level import statements not at the top of the file, since we have many files that use this pattern and are not easy to fix.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-abeamon avatar May 02 '23 15:05 sfc-gh-abeamon

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Duration 0:16:16
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 15:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 02 '23 15:05 fdb-windows-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Duration 0:20:43
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 15:05 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Duration 0:29:05
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 15:05 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Duration 0:33:58
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 16:05 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 7ed250e3a840048046b9945ee71e3b23dd3c31b5
  • Duration 1:23:39
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar May 02 '23 16:05 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar May 02 '23 17:05 fdb-windows-ci

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 0:06:18
  • Result: :x: FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 17:05 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 0:18:11
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 17:05 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 1:09:25
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 18:05 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 1:22:23
  • Result: :x: FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 18:05 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 1:38:15
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar May 02 '23 18:05 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 0:17:28
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 18:05 foundationdb-ci

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 0:40:04
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 0:56:36
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 1:01:33
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar May 02 '23 19:05 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b5d6ec240cdab6abf2c6c801288c59cf38c5245e
  • Duration 1:28:02
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci avatar May 02 '23 20:05 foundationdb-ci