axlearn icon indicating copy to clipboard operation
axlearn copied to clipboard
verified publisher icon apple

Add `@no_side_effects`.

Open apghml opened this issue 1 year ago • 2 comments

apghml avatar Aug 09 '24 21:08 apghml

It is similar to @nowrap? https://github.com/apple/axlearn/pull/797

ds-hwang avatar Nov 13 '24 05:11 ds-hwang

Yes, it's the same except that it checks whether the function has side effects and errors if so. I had previously done a different PR that actually added an exact @nowrap decorator, but Ruoming advocated against that functionality at the time, so it never got merged.

apghml avatar Nov 13 '24 18:11 apghml

Closing this PR due to inactivity. Feel free to reopen if you would like to continue the work.

changlan avatar Jul 26 '25 00:07 changlan