axlearn icon indicating copy to clipboard operation
axlearn copied to clipboard

chore(axlearn): Fix typos

Open tony opened this issue 1 year ago • 4 comments

Changes

Typo fixes

Tool-assisted (via typos --format brief --write-changes **/*.py via typos-cli). The rest of the effort is fine-tooth combing that output.

Aside: If you attempt this in the future in any way, do so carefully. This generated many false positives due to the nature of the library (e.g. nd -> and, empted -> emptied).

_typos.toml config used
[default]
extend-ignore-identifiers-re = [
    # *sigh* this just isn't worth the cost of fixing
    ".*nd.*",
    ".*ND.*",
    ".*preempt.*",
    ".*empt.*",
    ".*helpfull.*",
    ".*dout.*",
    ".*whos.*",
    ".*your.*",
    ".*stakeboard.*",
    ".*sur.*",
]

[files]
extend-exclude = ["*.vocab"]

tony avatar Apr 24 '24 22:04 tony

@markblee Yes!

Rebased against latest against main at 8419778.

tony avatar Apr 25 '24 00:04 tony

Changes:

  • Squashed (fixupd) https://github.com/apple/axlearn/pull/420#discussion_r1578638676 into main commit.
  • Rebased against main at b48ecc0.
    • Handmade fixes and new catches of this commit
  • PR Description: Added _typos.toml to the description, so it can be looked up later

tony avatar Apr 27 '24 11:04 tony

@markblee Rebased, fixed pylint error.

tony avatar May 15 '24 02:05 tony

@markblee Rebased again.

It's failing on pre-commit in re: contextlib2-21.6.0-py2.py3-none-any.whl:

Downloading smmap-5.0.1-py3-none-any.whl (24 kB)
Downloading yarl-1.9.4-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (304 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 304.3/304.3 kB 28.3 MB/s eta 0:00:00

Downloading contextlib2-21.6.0-py2.py3-none-any.whl (13 kB)
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    unknown package:
        Expected sha256 bd95cee8511584b67ddc0ba465c3f1edeb5708d833ee02af1206b4486f1d9096
             Got        47b9fd1f3a7e0f372c0bf5a8f1521ca39a84ae3b098e3f73a3f62bc6d0b8f0fe


Exited with code exit status 1

tony avatar May 15 '24 22:05 tony

@markblee Up to give it another shot? Rebased again (last run)

tony avatar May 29 '24 22:05 tony