dotnet-client icon indicating copy to clipboard operation
dotnet-client copied to clipboard

Deprecate TouchAction and MultiTouchAction

Open KazuCocoa opened this issue 4 years ago • 3 comments

Description

https://github.com/appium/appium/issues/16009

Details

We'd like to deprecate old touch actions endpoints. maybe https://github.com/appium/appium-dotnet-driver/blob/4570d11267572b861554142d39d4452d853e6118/src/Appium.Net/Appium/MultiAction/MultiAction.cs and https://github.com/appium/appium-dotnet-driver/blob/4570d11267572b861554142d39d4452d853e6118/src/Appium.Net/Appium/MultiAction/TouchAction.cs ?

KazuCocoa avatar Oct 25 '21 21:10 KazuCocoa

Got it, it'll be deprecated in v4.4

laolubenson avatar Oct 25 '21 21:10 laolubenson

@KazuCocoa Are you deprecating the entire POST /session/:session_id/touch resource or just some of it's child endpoints i.e. click, move, down, scroll etc

laolubenson avatar Oct 26 '21 12:10 laolubenson

The main deprecation is the endpoint.

  • POST session/:session_id/touch/perform
  • POST session/:session_id/touch/multi/perform

In Python and Ruby, I'm going to drop the relevant classes as well (so it will include click etc) since similar code is not in their selenium code side as well. I'll prepare examples to achieve click, move etc with W3C actions as working test code i.e. https://github.com/appium/ruby_lib_core/pull/348

ah, or do you mean like https://github.com/appium/appium-base-driver/blob/master/lib/protocol/routes.js#L285-L286 ?

KazuCocoa avatar Oct 26 '21 16:10 KazuCocoa

@akinsolb did we deprecated the above? or it's something we need to do?

Dor-bl avatar Oct 22 '22 19:10 Dor-bl

@KazuCocoa https://github.com/appium/appium-dotnet-driver/pull/548 should address this

Dor-bl avatar Nov 06 '22 05:11 Dor-bl

Resolved under https://github.com/appium/appium-dotnet-driver/pull/548

Dor-bl avatar Nov 07 '22 16:11 Dor-bl