react-gears icon indicating copy to clipboard operation
react-gears copied to clipboard

chore: remove unnecessary props from FeedbackButtton

Open junhongwang418 opened this issue 3 years ago • 3 comments

recipient, cc, and feature are just passed to the callback of onSubmit. Since we require onSubmit, the client already has access to recipient, cc, feature.

junhongwang418 avatar Aug 25 '22 19:08 junhongwang418

Deploy Preview for stately-chebakia-3a1e20 ready!

Name Link
Latest commit 9a17de0921a9f34e34a5d7f4da2173ade5b2260d
Latest deploy log https://app.netlify.com/sites/stately-chebakia-3a1e20/deploys/6307c90021ef67000853c1b5
Deploy Preview https://deploy-preview-1059--stately-chebakia-3a1e20.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 25 '22 19:08 netlify[bot]

Released prerelease version 7.7.1-one-remove-unnecessary-props-2eba7c8.0. You may now run npm install @appfolio/react-gears@one-remove-unnecessary-props

github-actions[bot] avatar Aug 25 '22 19:08 github-actions[bot]

This is a major breaking change. There are many usages of these props and removing them will require many changes in apm_bundle: https://cs.github.com/?scopeName=All+repos&scope=&q=repo%3Aappfolio%2Fapm_bundle+%3CFeedBackButton

If you are willing to fix all the cases where these props are used, we can merge this.

JeremyRH avatar Aug 26 '22 21:08 JeremyRH