reactivesearch icon indicating copy to clipboard operation
reactivesearch copied to clipboard

More than 2 suggested categories in categorySearch?

Open iseabock opened this issue 6 years ago • 4 comments

Issue Type:

I think this falls into the category of enhancement

Platform:

Web

Description:

Is there currently a way, or is it possible for you to add more than just two suggested categories in the categorySearch?

screen shot 2019-02-01 at 4 53 55 pm

iseabock avatar Feb 02 '19 00:02 iseabock

Sounds good. Open to accepting PRs on this.

We can maybe introduce a prop called categorySuggestionsListSize (open to suggestions on the prop name to make it more intuitive)

Refer the code block here for implementation details: https://github.com/appbaseio/reactivesearch/blob/next/packages/web/src/components/search/CategorySearch.js#L693-L703

metagrover avatar Feb 04 '19 13:02 metagrover

Shall I work on this...I have to work on a contribution to an open source project for an assignment in our university..

kvin97 avatar Sep 16 '19 11:09 kvin97

Hey @kvin97 You can work on this.

jyash97 avatar Sep 16 '19 11:09 jyash97

@jyash97 @metagrover please review the above PR for the added categorySuggestionsListSize prop. Now it can be added as categorySuggestionsListSize={*} in CategorySearch component.

kvin97 avatar Oct 03 '19 05:10 kvin97