apostrophe icon indicating copy to clipboard operation
apostrophe copied to clipboard

Trashed piece gets rescued if you click on the title in the trash.. unexpected behavior

Open bgantick opened this issue 5 years ago • 3 comments

To Reproduce Steps to reproduce the behavior:

  1. Go to any piece in the trash.
  2. Click on piece title
  3. Piece automatically gets rescued with no prompt
  4. Generic notification that piece has been rescued

Expected behavior I would expect clicking on a piece in the trash to bring up the editor modal for that piece.

This could be bad.. user clicks on thing in trash to check to see what a field value is ... thing leaves trash and gets lost in a sea of 1000 pieces some of which might have the same title or.. user clicks on user in the trash to make sure login is disabled as well as trashed ... trashed user gets republished

bgantick avatar Mar 06 '20 14:03 bgantick

Yep, it's lame. UX Improvised By Boutell ™

Unless workflow is present, the semantics of the trash are a little tricky to allow editing with. But for 2.x one possible fix that wouldn't open too many cans of technical worms would be to allow read-only access to the editing modal, with a prominent "you can rescue this to make it editable again" button, maybe. For 3.x there ought to be a Larger Conversation about the relationships between trash, published, draft and live.

cc @stuartromanek @localghost443 @abea

On Fri, Mar 6, 2020 at 9:54 AM Brian Gantick [email protected] wrote:

To Reproduce Steps to reproduce the behavior:

  1. Go to any piece in the trash.
  2. Click on piece title
  3. Piece automatically gets rescued with no prompt
  4. Generic notification that piece has been rescued

Expected behavior I would expect clicking on a piece in the trash to bring up the editor modal for that piece.

This could be bad.. user clicks on thing in trash to check to see what a field value is ... thing leaves trash and gets lost in a sea of 1000 pieces some of which might have the same title or.. user clicks on user in the trash to make sure login is disabled as well as trashed ... trashed user gets republished

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/2155?email_source=notifications&email_token=AAAH27KYR2WGITY46R7OW6TRGEFCRA5CNFSM4LDBZFVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITEB3IQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27OLUHJOOWUCXFLRFYDRGEFCRANCNFSM4LDBZFVA .

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

boutell avatar Mar 08 '20 15:03 boutell

I could imagine something like the attached, where all fields are disabled and clicking Restore re-opens the modal as a rescued and editable piece.

image

stuartromanek avatar Mar 09 '20 13:03 stuartromanek

Exactly what I was thinkin'.

On Mon, Mar 9, 2020 at 9:54 AM Stuart Romanek [email protected] wrote:

I could imagine something like the attached, where all fields are disabled and clicking Restore re-opens the modal as a rescued and editable piece.

[image: image] https://user-images.githubusercontent.com/1889830/76219242-e840ef80-61eb-11ea-8d1c-b4eb78cdf47e.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apostrophecms/apostrophe/issues/2155?email_source=notifications&email_token=AAAH27LTL6N6LIZDU5WUEBLRGT7JNA5CNFSM4LDBZFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHG7OA#issuecomment-596537272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAH27MJMGJLBUKA4SY6BTLRGT7JNANCNFSM4LDBZFVA .

--

THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER APOSTROPHECMS | apostrophecms.com | he/him/his

boutell avatar Mar 09 '20 13:03 boutell