useQuery yields incorrect loading state during SSR

[cdaringe]

Intended outcome:

useQuery to yield {loading: false, data: { ...data-from-cache... }}

Actual outcome:

useQuery yields {loading: true, data: { ...data-from-cache...}}

How to reproduce the issue:

an easily cloneable, runnable reproduction is found here: https://github.com/cdaringe/apollo-bad-ssr-state.

problem

on ssr the following events occur, ending in an incorrect SSR state:

• apollo client created
• app render begins, useQuery executes
• await getDataFromTree(app) occurs
• useQuery completes, client cache updated with query results. last result of useQuery correctly has state of {loading: false, data ...good-data...}
• ReactDOM.renderToString(...) is called, useQuery returns { loading: true, error: undefined, data: ...good-data... }

by debugging in my component on SSR, useQuery went thru the following transitions in a single request:

1. {loading: true, data: undefined}, on when first calling <App />
2. {loading: false, data: CORRECT_DATA}, while getDataFromTree was awaiting useQuery to settle
3. {loading: true, data: CORRECT_DATA}, on ReactDom::renderToString. blast! loading should be false 😢 .

Version

System: OS: macOS 10.15.4 Binaries: Node: 13.13.0 - ~/.nvm/versions/node/v13.13.0/bin/node Yarn: 1.19.1 - ~/.yarn/bin/yarn npm: 6.14.4 - ~/.nvm/versions/node/v13.13.0/bin/npm Browsers: Chrome: 81.0.4044.138 Firefox: 75.0 Safari: 13.1 npmPackages: @apollo/client: 3.0.0-beta.39 => 3.0.0-beta.39 @apollo/react-ssr: ^4.0.0-beta.1 => 4.0.0-beta.1

[Shtokarev]

Exactly the same behaviour @apollo/client: 3.0.0-beta.50