graphql-subscriptions icon indicating copy to clipboard operation
graphql-subscriptions copied to clipboard

Release 3.0

Open hwillson opened this issue 4 years ago • 10 comments

This release PR will serve to collect significant new features, deprecation warnings, and minor breaking changes that we intend to release in [email protected]. It should not be merged until we're ready to release 3.0.

hwillson avatar Nov 25 '21 17:11 hwillson

Any updates?

maxpain avatar Jan 16 '22 06:01 maxpain

Are there any more breaking changes planned? If not, could the release happen? Or even if, could the release happen? There's always the next major version for more breaking changes.

Narretz avatar Jan 28 '22 19:01 Narretz

@hwillson hey this has been blocking a major version upgrade of graphql codegen for us, any chance you could release soon?

tubbo avatar Feb 11 '22 18:02 tubbo

Same 👯

daphnesmit avatar Apr 04 '22 12:04 daphnesmit

Any new improvements planned? What's holding you from merging it finally?

Hetch3t avatar May 28 '22 21:05 Hetch3t

Any news?

maxpain avatar Jun 20 '22 02:06 maxpain

1 year and still not ready? not to be rude or anything, what's the hold-up

Ryiski avatar Nov 27 '22 10:11 Ryiski

Any update would be appreciated? :pray:

aidenfoxx avatar Nov 29 '22 14:11 aidenfoxx

Hello,

I am reading the latest (V4) Apollo documentation that recommend using the graphql-subscriptions library with subscription. However, the type, as mentioned by many people in this thread, are not compatible. I believe this pull request will solve this issue. Apollo is quite a popular and the are fading out their v3 for v4.

There is a discussion in the graphql-codegen that generate code to use with Apollo that highlight that the issue is not on the generated type. Someone in the Codegen discussion gives a quick hack to fix the issue:

subscribe: () => ({
        [Symbol.asyncIterator]: () => pubsub.asyncIterator('NUMBER_INCREMENTED'),
      }),

However, the hack is only for type. Doing:

subscribe: () => pubsub.asyncIterator("NUMBER_INCREMENTED") as any,

Also fix the problem.

The first comment of this thread is from Nov 25, 2021 and we are now almost over with 2022. The direction of this library is unclear to me but it is an helpful one and it would be great to see it moving forward to continue to work with TypeScript without hacks. Have a great day.

MrDesjardins avatar Dec 14 '22 18:12 MrDesjardins

@hwillson Is this something that is still on the agenda? Migrating to apollo v4 would be a lot more pleasant without conflcting types.

Aeolun avatar Aug 10 '23 03:08 Aeolun