graphql-subscriptions icon indicating copy to clipboard operation
graphql-subscriptions copied to clipboard

Consider renaming "asyncIterator" to "register"

Open coodoo opened this issue 7 years ago • 1 comments

From a first glance of the signature

asyncIterator<T>(triggers: string | string[]): AsyncIterator<T>;

Seems it's more like a register method to add one or more event names to listen to, does it make sense to consider renaming it to just that?

coodoo avatar Jun 09 '18 06:06 coodoo

I feel like that would make it sound like something where you attach an event handler, instead of what it actually does. Also, I don't think this is a good reason to break backwards compatibility.

grantwwu avatar Oct 02 '18 00:10 grantwwu