a-plus icon indicating copy to clipboard operation
a-plus copied to clipboard

Double-check if we need so many modals

Open mtthwhggns opened this issue 5 years ago • 4 comments

Every page currently includes a page_modal and a file_modal, although they're not displayed until activated.

They have some accessibility problems when they are activated (detailed in the audit, link below). This is definitely fixable, but before we put time into this, let's double-check whether they are the best way to display the content.

Feel free to share any thoughts here. @saarasat - Jaakko said you're working on something related to this.

Related: https://apluslms.github.io/accessibility-audit/patterns/fixable-a/modals/

mtthwhggns avatar Jun 25 '20 10:06 mtthwhggns

Jaakko already had ideas about removing the modal dialogs in the chapter/exercise pages. The submission feedback could be opened within the exercise frame instead of opening modals. Saara is working on this.

markkuriekkinen avatar Jun 25 '20 11:06 markkuriekkinen

To update what I will be working, is first and foremost removing this modal, present in questionnaires:

image

So at the moment, the other modals (especially the ones not related questionnaires) are not going to be worked by me anytime soon.

saarasat avatar Jul 03 '20 10:07 saarasat

PR https://github.com/apluslms/a-plus/pull/640 removed the chapter modal dialog from questionnaire exercises.

Randomized questionnaires still depend on the modal dialog: https://github.com/apluslms/a-plus/issues/785

markkuriekkinen avatar Feb 11 '21 18:02 markkuriekkinen

There exists an aria-modal attribute that might be useful. It removes the need for aria-hidden from the modal background.

ihalaij1 avatar Sep 19 '23 12:09 ihalaij1