swagger-node-runner icon indicating copy to clipboard operation
swagger-node-runner copied to clipboard

Added support to sway 2 by bumping dep version and fixing tests

Open idanw206 opened this issue 7 years ago • 17 comments

idanw206 avatar Aug 29 '18 17:08 idanw206

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Aug 29 '18 17:08 googlebot

I signed it!

idanw206 avatar Aug 29 '18 17:08 idanw206

CLAs look good, thanks!

googlebot avatar Aug 29 '18 17:08 googlebot

@theganyo any plan to roll this out? thanks!

chrislukkk avatar Sep 06 '18 15:09 chrislukkk

@theganyo can you please respond? thanks!

idanw206 avatar Oct 04 '18 16:10 idanw206

There are tons of fixes in Sway 2.0 and some relate to array type which really required. I also would appreciate this release as well. Thanks

maziyarpanahi avatar Oct 10 '18 07:10 maziyarpanahi

Same here. Really need the fixes for arrays with a single element only. Please update the lib.

meisterlampe avatar Nov 28 '18 12:11 meisterlampe

Can any of you check this out? @earth2marsh @gbrail @theganyo @whitlockjc @WWitman

idanw206 avatar Nov 30 '18 13:11 idanw206

If you are really in need for the latest pull requests you can use my fork and I have already merged the pull requests which I am using it in my production: https://github.com/multivacplatform/swagger-node-runner

Use it like this:

"swagger-express-runner": "[email protected]:multivacplatform/swagger-node-runner.git",

Or you can fork it yourself and do the changes. Either way, when the maintainer comes back you can switch to the original repo with no problem. Hope this helps.

maziyarpanahi avatar Nov 30 '18 18:11 maziyarpanahi

@theganyo Can we get this in? This seems to solve CVE-2018-3750 @earth2marsh @gbrail @whitlockjc @WWitman Anyone?

adityaguru149 avatar Jan 29 '19 13:01 adityaguru149

Bump! @theganyo,@earth2marsh, @gbrail, @whitlockjc, @WWitman

robert-claypool avatar Jan 30 '19 06:01 robert-claypool

I went ahead and created npm packages to solve this. https://www.npmjs.com/package/swagger-express-mw1 https://www.npmjs.com/package/swagger-node-runner1

These are based on forked repo from https://github.com/multivacplatform/swagger-node-runner Thanks to @maziyarpanahi

We can use these for now and wait for apigee-127 to fix the original package

adityaguru149 avatar Feb 07 '19 06:02 adityaguru149

Great! Many thanks @adityaguru149 👍

maziyarpanahi avatar Feb 07 '19 10:02 maziyarpanahi

bump @theganyo,@earth2marsh, @gbrail, @whitlockjc, @WWitman

svsg-dmitrib avatar Jul 23 '19 16:07 svsg-dmitrib

Do the contributors of this project need help? This has been ignored for a while - I can help if anything is needed as I would like this fix as well. AKA bump

camsjams avatar Aug 01 '19 18:08 camsjams

Since I've looked at this thread more than once, I figured I would help future people out, please see: How to migrate a Node JS Express project out of Swagger-Express

Note: I am not associated with either project but just wanted to share a migration guide.

camsjams avatar Aug 01 '19 23:08 camsjams

Any chance to see this merged? This would really help a lot of people, and would likely require no changes in swagger-node-runner 🤔 cc @theganyo

WaldoJeffers avatar Oct 27 '21 16:10 WaldoJeffers