crawlee-python icon indicating copy to clipboard operation
crawlee-python copied to clipboard

feat: Added get_public_url method to KeyValueStore

Open naaa760 opened this issue 1 year ago • 4 comments

Description

This pull request introduces the get_public_url method to the KeyValueStore class. This method generates a file URL for a given key, allowing for easy access to stored files. The URL is constructed dynamically based on the storage directory and store name.

Issues

Fix: #514

Testing

  • Unit tests were added to verify the functionality of the get_public_url method. All existing and new tests were executed successfully to ensure no regressions.

Checklist

  • [ ] CI passed

naaa760 avatar Oct 03 '24 16:10 naaa760

Hi @naaa760, you're adding almost 190k new lines of code, are you sure that's correct?

vdusek avatar Oct 03 '24 16:10 vdusek

Hi @naaa760, you're adding almost 190k new lines of code, are you sure that's correct?

I Update the deployment dependencies, that's how it adds up lines of code and yeah it's right!

naaa760 avatar Oct 03 '24 17:10 naaa760

The PR title does not conform to the required format. To ensure successful processing, please begin the title with a prefix indicating the type of change (e.g., feat, fix, docs, etc.). For example, you could modify the title to 'feat: Added get_public_url method to KeyValueStore'.

belloibrahv avatar Oct 03 '24 17:10 belloibrahv

I Update the deployment dependencies, that's how it adds up lines of code and yeah it's right!

Well, certainly your PR should not include your Python environment - the env directory.

vdusek avatar Oct 04 '24 14:10 vdusek