dredd icon indicating copy to clipboard operation
dredd copied to clipboard

Resolves dependencies warnings

Open artem-zakharchenko opened this issue 6 years ago • 1 comments

:rocket: Why this change?

  • See #1628 for more detailed issue description

  • [x] Updates eslint-config-airbnb-base to peer depend on the modern eslint
  • [x] Removes commitlint-circle and uses commitlint --from=origin/master on the CI
  • [ ] Solves fury adapter bundled dependency in dredd-transactions

:memo: Related issues and Pull Requests

  • Closes #1628

:white_check_mark: What didn't I forget?

  • [x] To write docs
  • [x] To write tests
  • [ ] To put Conventional Changelog prefixes in front of all my commits and run npm run lint

artem-zakharchenko avatar Dec 13 '19 10:12 artem-zakharchenko

Bump in eslint-config-airbnb-base includes a breaking change, specifically certain ESLint rules that were nor set before. Those newly presented rules cause quality-checks job to fail on CircleCI.

Certain rules are not compatible with how we distribute packages (i.e. dredd-transactions cannot use object spreading as it's not compiled and object spreading is not yet supported natively). I'll cherry-pick and fix linting errors that are applicable to our situation and disable the others.

artem-zakharchenko avatar Dec 13 '19 10:12 artem-zakharchenko