core icon indicating copy to clipboard operation
core copied to clipboard
verified publisher icon api-platform

feat: Add compatibility with doctrine/orm 3.0

Open ddeboer opened this issue 2 years ago • 3 comments

Q A
Branch? main
Tickets Closes api-platform/api-platform#2633
License MIT
Doc PR

Introduce compatibility with doctrine/orm 3.0.

ddeboer avatar Feb 12 '24 11:02 ddeboer

nice! can you run the doctrine orm component tests? Also it looks like phpstan isn't happy

soyuka avatar Feb 12 '24 16:02 soyuka

Solved some problems, but others are popping up. Is there any documentation on how to run the tests and checks locally?

ddeboer avatar Feb 15 '24 13:02 ddeboer

Hi, thanks for the patch, I guess that our lowest tests would fail not having the new ClassMetadata? Still a bunch of red jobs though. Yes the documentation is at: https://github.com/api-platform/core/blob/main/CONTRIBUTING.md#tests

soyuka avatar Feb 16 '24 08:02 soyuka

waiting for https://github.com/symfony/symfony/commit/ac07f3eb7842478d7ef736c8f280a1a16b7548e9

soyuka avatar Mar 01 '24 14:03 soyuka

@soyuka You need this commit in a release? If yes, which branch do you need (5.4, 6.4, 7.0, the three of them)?

fabpot avatar Mar 01 '24 14:03 fabpot

@fabpot yes 6.4 and 7.0 would be great but I'd like to be sure it's the only blocker

soyuka avatar Mar 01 '24 15:03 soyuka

Thanks @ddeboer fo starting this went on my branch to continue as gh actions was buggy

soyuka avatar Mar 01 '24 21:03 soyuka

My pleasure @soyuka. Thank you for wrapping this up.

ddeboer avatar Mar 02 '24 18:03 ddeboer