eds-scikit icon indicating copy to clipboard operation
eds-scikit copied to clipboard

Fix: Switch default `to_koalas` in `HiveData._read_table`. to False

Open Vincent-Maladiere opened this issue 2 years ago • 1 comments

Description

The to_koalas argument has been deprecated in _read_table since it wasn't used. Returning koalas DataFrame during this step allows for more predictable behavior and fewer worries due to OOM errors.

When to_koalas is set to True, we raise a warning to indicate that this argument is not used. Since this argument is True by default, we raise this warning for every table to be read, which is unpleasant for the user.

Therefore, this PR suggests setting to_koalas to False by default.

Checklist

  • [x] If this PR is a bug fix, the bug is documented in the test suite.
  • [x] Changes were documented in the changelog (pending section).
  • [x] If necessary, changes were made to the documentation (eg new pipeline).

Vincent-Maladiere avatar Mar 30 '23 14:03 Vincent-Maladiere

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.35%. Comparing base (c15119c) to head (ab26aad). Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          80       80           
  Lines        2421     2421           
=======================================
  Hits         2018     2018           
  Misses        403      403           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 22 '25 15:04 codecov[bot]