ZOOKEEPER-4819 Fix can't seek for writable tls server if connected to readonly server

Open luoxiner opened this issue 1 year ago • 3 comments

ClientCnxn::pingRwServer uses raw socket to issue "isro" 4lw command. This results in unsuccessful handshake to tls server. Use SSLSocket when zookeeper.client.secure is set to true.

associated jira issue ZOOKEEPER-4819

Oct 10 '24 14:10 luoxiner

Great! I think we need tests.

Oct 12 '24 05:10 kezhuw

Great! I think we need tests.

Hi @kezhuw, I added a test case based on the ReadOnlyModeTest. Please take a look.

Oct 13 '24 04:10 luoxiner

@kezhuw @eolivelli Thank you for your reply. I have changed my code based on the suggestions. Please take a look.

Oct 14 '24 14:10 luoxiner

Looks good from my side.

@eolivelli Would you want take another look ?

Oct 23 '24 05:10 kezhuw

@luoxiner Thank you for your contribution! Merged.

Nov 27 '24 01:11 kezhuw