zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-3493] "Export all data as csv" not exporting all data

Open skyer9 opened this issue 4 years ago • 3 comments

What is this PR for?

First of all, thanks to https://github.com/babokim/zeppelin/tree/presto_acl_20160809 My work is heavily based on his code & idea.

Second, this is for JDBCInterpreter only. But, you can find it is easy porting to other Interpreter.

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3493

How should this be tested?

  • execute select sql responsing more then 1000 rows.
  • check CSV(ALL) menu works.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? not necessary, but good for convenience

skyer9 avatar Dec 03 '21 14:12 skyer9

detailed action

  • when execute sql, all data is saved to file
  • when requested, download saved file.
  • after four hour, saved file is deleted automatically.
  • when there is no saved file, displayed data is downloaded.

skyer9 avatar Dec 03 '21 14:12 skyer9

@skyer9 Thanks for the contribution, could you paste a screenshot about how this feature is used by users?

zjffdu avatar Dec 03 '21 15:12 zjffdu

https://www.skyer9.pe.kr/wordpress/wp-content/uploads/2021/12/2021-12-03-01.png

i added screenshot. but it can take 10 seconds or more. it's image is served on nano aws server

skyer9 avatar Dec 03 '21 22:12 skyer9