[ZEPPELIN-3167]

Open NicolasRouquette opened this issue 7 years ago • 1 comments

What is this PR for?

Split the R assignment in two steps, evaluation and assignment, such that the tryCatch in the R eval loop can detect errors and report them to Zeppelin.

What type of PR is it?

[Bug Fix]

Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
https://issues.apache.org/jira/browse/ZEPPELIN-3167

How should this be tested?

First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?

Nov 03 '18 20:11 NicolasRouquette

Thanks @NicolasRouquette for the contribution. Looks like CI test is failing at

Results :

Failed tests: 
  SparkRInterpreterTest.testSparkRInterpreter:88 expected:<SUCCESS> but was:<ERROR>

Tests run: 106, Failures: 1, Errors: 0, Skipped: 0

Could you check and try make the test pass?

Nov 05 '18 16:11 Leemoonsoo