xmlgraphics-commons icon indicating copy to clipboard operation
xmlgraphics-commons copied to clipboard
verified publisher icon apache

XGC-148: drop commons-io dependency

Open vlsi opened this issue 2 months ago • 4 comments

Fixes https://issues.apache.org/jira/browse/XGC-148

TODO:

  • [x] IOUtils.closeQuitely — replaced with try-with-resources
  • [x] IOUtils.toString(Reader) — implemented a function in test (it was used in a single test only)
  • [x] IOUtils.copy. Java 9 has InputStream.transferTo(OutputStream)
  • [x] IOUtils.toByteArray. Java 9 has InputStream.readAllBytes()
  • [x] commons.io.output.ByteArrayOutputStream. I see that there were no consistent use of commons.ByteArrayOutputStream, so I replaced all the usages with java.io.ByteArrayOutputStream
  • [x] EndianUtils.readSwappedInteger

vlsi avatar Nov 06 '25 06:11 vlsi

I see the CI checks fail, and I suggest a fix for it: https://github.com/apache/xmlgraphics-commons/pull/33

vlsi avatar Nov 06 '25 11:11 vlsi

@simonsteiner1984 , any thoughts?

vlsi avatar Nov 10 '25 18:11 vlsi

Is there a reason of not merging the PR?

Frankly, it looks sad to miss myself here: https://github.com/apache/xmlgraphics-commons/graphs/contributors

vlsi avatar Nov 12 '25 07:11 vlsi

https://github.com/apache/xmlgraphics-commons/commit/22e04a9b0a5018081ebebef09b7c8234e8927e75

simonsteiner1984 avatar Nov 12 '25 08:11 simonsteiner1984