Fixed build error and warnings when building VTA_TSIM with TVM

Open k0nze opened this issue 2 years ago • 3 comments

When building VTA_TSIM from TVM, an error occurred, which was fixed by changing the signature of DPIModule (src/dpi/module.cc) from std::string to tvm::runtime::String. Additionally, override statements were added to DPIModule methods which override virtual methods of DPIModuleNode (src/dpi/module.h) to get rid of warnings when building VTA_TSIM.

Sep 18 '23 06:09 k0nze

Good catch, and looks like this was introduced by https://github.com/apache/tvm/pull/14902 may in May.

Sep 18 '23 13:09 Lunderberg

Are there plans to merge this PR and https://github.com/apache/tvm-vta/pull/38?

Oct 31 '23 12:10 k0nze

Unfortunately, I don't have commit privs for the tvm-vta repo, but I've reached out to ask on it.

Oct 31 '23 16:10 Lunderberg