tvm-rfcs icon indicating copy to clipboard operation
tvm-rfcs copied to clipboard
verified publisher icon apache

[RFC] A proposed update to the Docker images ci_* tag pattern

Open leandron opened this issue 3 years ago • 10 comments

This RFC proposes a new format to keep our Docker images used in CI, moving away from our current incremental numbering to a more meaningful format that contains a timestamp and the latest hash from the repository used to generate such images.

cc @areusch @driazati @Mousius @konturn @junrushao1994 @masahi @gromero @mehrdadh @tqchen for visibility and reviews

leandron avatar Apr 08 '22 14:04 leandron

@Mousius i support - instead of _ (when running docker/bash.sh, you can then use _ as a sort of rule of thumb to determine if you're referencing a variable-driven revision or a specific one)

areusch avatar Apr 11 '22 17:04 areusch

Just friendly note here, that as I'm not hearing opposition, I'll move into creating a a PR to update the documentation and reflect the changes proposed here where appropriate.

leandron avatar Apr 20 '22 16:04 leandron

@leandron, looking at Docker Hub (https://hub.docker.com/_/hello-world) it would appear the convention for image names is to use - there as well (i.e. tlcpack/ci-cpu rather than tlcpack/ci_cpu) can we go for that one?

Mousius avatar Apr 20 '22 16:04 Mousius

@leandron, looking at Docker Hub (https://hub.docker.com/_/hello-world) it would appear the convention for image names is to use - there as well (i.e. tlcpack/ci-cpu rather than tlcpack/ci_cpu) can we go for that one?

Sure. I’ll push an updated version with this and @gromero’s suggestion as well.

leandron avatar Apr 20 '22 16:04 leandron

@leandron should we merge this? I think the change has landed in Jenkinsfile now

areusch avatar May 12 '22 17:05 areusch

cc @Mousius @gromero can you approve?

areusch avatar May 12 '22 17:05 areusch

cc @Mousius @gromero can you approve?

@leandron Hi. Are you still planing to change https://github.com/apache/tvm-rfcs/pull/66#discussion_r854052265 ?

gromero avatar May 13 '22 07:05 gromero

@Mousius I don't have any further comments on it. Are you ok with the current state of this RFC? If so, could you please approve the changes so I can merge it? Thanks!

gromero avatar Jun 07 '22 01:06 gromero

@leandron, looking at Docker Hub (https://hub.docker.com/_/hello-world) it would appear the convention for image names is to use - there as well (i.e. tlcpack/ci-cpu rather than tlcpack/ci_cpu) can we go for that one?

Sure. I’ll push an updated version with this and @gromero’s suggestion as well.

@gromero the above change is still pending as far as I can see?

Mousius avatar Jun 07 '22 08:06 Mousius

@leandron, looking at Docker Hub (https://hub.docker.com/_/hello-world) it would appear the convention for image names is to use - there as well (i.e. tlcpack/ci-cpu rather than tlcpack/ci_cpu) can we go for that one?

Sure. I’ll push an updated version with this and @gromero’s suggestion as well.

@gromero the above change is still pending as far as I can see?

@Mousius hrm right. So we'll need @leandron to make the next move here.

gromero avatar Jun 09 '22 20:06 gromero