trafodion icon indicating copy to clipboard operation
trafodion copied to clipboard

[TRAFODION-3264] eliminate unneeded function call in Lob-related functions

Open wenjun-zhu opened this issue 7 years ago • 7 comments

in file core/sql/executor/ExExeUtilLoad.cpp, lines like:

	    ex_expr::exp_return_type exprRetCode =	
	      lobTdb().inputExpr_->eval(NULL, 	
					workAtp_);

call function eval(), with first parameter NULL.

Then code in ex_expr::evalClauses() accesses NULL pointer, so the server aborts.

As @sandhyasun said, this invocation is unneeded, so remove these code.

wenjun-zhu avatar Jan 28 '19 03:01 wenjun-zhu

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 28 '19 03:01 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 28 '19 03:01 Traf-Jenkins

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3113/

Traf-Jenkins avatar Jan 28 '19 03:01 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 28 '19 03:01 Traf-Jenkins

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/3113/

Traf-Jenkins avatar Jan 28 '19 06:01 Traf-Jenkins

Did you run all the extract commands and "update lob" commands and ensure this expression eval can be eliminated ? Did executor/TEST130 pass ? And the JDBC LOB tests that are part of regressions ? They go through this code path.

sandhyasun avatar Jan 28 '19 15:01 sandhyasun

We can merge this in if we get the results on executor/TEST130 and the JDBC lob tests. Please update this PR with the results.

sandhyasun avatar Feb 06 '19 22:02 sandhyasun