trafodion [trafodion-3211]refactor the usage of setDiagsArea()

Two points:

append a letter x to the function name setDiagsArea()
add a new function shareDiagsArea(), which increase the refCount of the source ComDiagsArea.

This PR serves as a code base for further discussion. And the appendix letter x would be removed before merging.

Sep 29 '18 12:09 wenjun-zhu

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3006/

Sep 29 '18 12:09 Traf-Jenkins

Can one of the admins verify this patch?

Sep 29 '18 12:09 Traf-Jenkins

Can one of the admins verify this patch?

Sep 29 '18 12:09 Traf-Jenkins

Can one of the admins verify this patch?

Sep 29 '18 12:09 Traf-Jenkins

Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/3006/

Sep 29 '18 12:09 Traf-Jenkins

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3007/

Sep 30 '18 08:09 Traf-Jenkins

Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/3007/

Sep 30 '18 13:09 Traf-Jenkins

Looks like compGeneral/TEST006 might be coring.

Might want to run full regressions on a workstation for this change.

Oct 02 '18 22:10 DaveBirdsall

I don't see any comments in the JIRA on the change description. So trying to summarize here with a question .... Is the change to simply change all places (in ex)queu class and ExAtp class) where we do a setDiagsArea(da) followed by da->incrRefCount() to be done with one descriptive method - shareDiagsArea(da) ?

Nov 01 '18 20:11 sandhyasun