trafodion icon indicating copy to clipboard operation
trafodion copied to clipboard

[TRAFODION-3089] DatabaseMetaData.getIndexInfo not work well

Open mashengchen opened this issue 7 years ago • 17 comments

it's hard to update statistic message each time row datas change. so current version does not support CARDINALITY.

mashengchen avatar Jun 12 '18 01:06 mashengchen

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2742/

Traf-Jenkins avatar Jun 12 '18 01:06 Traf-Jenkins

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2742/

Traf-Jenkins avatar Jun 12 '18 03:06 Traf-Jenkins

It looks like the change made via https://github.com/apache/trafodion/pull/594 to make the squirel to work is being undone. Is that what you wanted?

selvaganesang avatar Jun 20 '18 18:06 selvaganesang

no, actually i remove the sb_histograms , because the MD schema does not have that table, also if there does not do update stastisitc, the CARDINALITY will not correct. i discuss with @venkat1m , he can explain more.

mashengchen avatar Jun 28 '18 06:06 mashengchen

@mashengchen, @selvaganesang, @venkat1m: Where does this change stand? Is it ready for merging? Does it require more work?

DaveBirdsall avatar Jul 10 '18 22:07 DaveBirdsall

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2879/

Traf-Jenkins avatar Jul 27 '18 07:07 Traf-Jenkins

Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2879/

Traf-Jenkins avatar Jul 27 '18 16:07 Traf-Jenkins

jenkins,retest

mashengchen avatar Aug 14 '18 05:08 mashengchen

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2944/

Traf-Jenkins avatar Aug 14 '18 05:08 Traf-Jenkins

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2944/

Traf-Jenkins avatar Aug 14 '18 10:08 Traf-Jenkins

@mashengchen, @selvaganesang, @venkat1m: Where does this change stand? Is it ready for merging? Does it require more work?

moscowgentalman avatar Aug 19 '18 10:08 moscowgentalman

@traflm this PR is for the bug which can get index in MD schema by the getIndexInfo api, but one can get result by using get indexes in trafci or sqlci

mashengchen avatar Dec 17 '18 07:12 mashengchen

@selvaganesang and @venkat1m: Do you have further comments? Or should I merge this?

DaveBirdsall avatar Dec 20 '18 02:12 DaveBirdsall

jenkins, retest

DaveBirdsall avatar Dec 20 '18 02:12 DaveBirdsall

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3072/

Traf-Jenkins avatar Dec 20 '18 02:12 Traf-Jenkins

Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/3072/

Traf-Jenkins avatar Dec 20 '18 04:12 Traf-Jenkins

It looks like GetStatistics API was displaying some information about the table itself to take into account the primary key earlier. I am assuming that the primary key acts like an implied index that needs to be displayed as part of GetStatistics API.

Yes. It is incorrect to use sb_histograms table, but I fear that the row pertaining to the primary key is being completely removed from the output with this change. Hence can you please attach the output of the catalog API before and after your change to determine if this change can be merged. So my comment about #594 still stands good

selvaganesang avatar Dec 21 '18 02:12 selvaganesang