trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard
verified publisher icon apache

Problems with TSPortDescriptor (TS API).

Open ywkaras opened this issue 5 years ago • 3 comments

  1. TSPortDescriptorParse() returns a pointer to a dynamically allocated object. There is no way to delete this object so it would be leaked ( https://github.com/apache/trafficserver/blob/85d50c2d7e916e7e30c698fdb1c32b1db7779455/src/traffic_server/InkAPI.cc#L8917 ).

  2. This capability is not fully tested in regression testing ( https://github.com/apache/trafficserver/blob/85d50c2d7e916e7e30c698fdb1c32b1db7779455/src/traffic_server/InkAPITest.cc#L1484 ).

This capability is not used in any core plugin.

ywkaras avatar Jun 12 '20 20:06 ywkaras

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Jun 27 '21 01:06 github-actions[bot]

I'd recommend changing it to take an opaque block of storage defined in "apidefs.h" that's the same size as an HttpProxyPort. AFAICT the struct is a POD so there's no destructor isue.

SolidWallOfCode avatar Nov 01 '21 23:11 SolidWallOfCode

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Nov 02 '22 02:11 github-actions[bot]