trafficcontrol icon indicating copy to clipboard operation
trafficcontrol copied to clipboard

fix(docker build router): docker build arg TMCAT & RPM, allow http resources

Open agirot opened this issue 3 years ago • 2 comments

Fix support of http rpm resources in Dockerfile (--build-arg TMCAT & RPM) of Traffic Router like other components.

Useful in CI/CD build context and work as expected with the current Example Build and Run of Dockerfile

Which Traffic Control components are affected by this PR?

  • Automation: Docker images

What is the best way to verify this PR?

Try docker build with--build-arg=TMCAT=https://<internal mirror>/tomcat-9.0.67-1.el8.noarch.rpm --build-arg=RPM=https://<internal mirror>/traffic_router.rpm

PR submission checklist

agirot avatar Dec 15 '22 09:12 agirot

This Dockerfile is no longer used, I think we can close this PR

ntheanh201 avatar Feb 23 '24 10:02 ntheanh201

This Dockerfile is no longer used

Removing those has been brought up before, the conclusion was that they needed to be left on the grounds that some people - only one of which I'm aware - still used them. So if someone wants to put time and effort into doing something with them and someone else thinks it's useful enough to review then we should just let them.

I would, however, be shocked if this PR were ever updated let alone reviewed. I also think that if someone were to bring up removing these dockerfiles again in the mailing list, they might find them lacking in defenders these days. And at that point, PRs like this one could definitely be closed.

ocket8888 avatar Feb 28 '24 17:02 ocket8888