trafficcontrol icon indicating copy to clipboard operation
trafficcontrol copied to clipboard

Remove api 1.x usage from infrastructure/docker scripts

Open mitchell852 opened this issue 4 years ago • 5 comments

I'm submitting a ...

  • improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • other

Current behavior:

There are also several instances of api/1.x being used in: infrastructure/docker/traffic_server_edge/run.sh infrastructure/docker/traffic_server_mid/run.sh infrastructure/docker/traffic_monitor/run.sh infrastructure/docker/README.md infrastructure/docker/traffic_ops/run.sh infrastructure/docker/traffic_stats/run.sh infrastructure/docker/traffic_vault/run.sh infrastructure/docker/traffic_router/run.sh

New behavior:

1.x will be removed from TC 6.0. Failure to migrate to api 2.x+ will result in broken scripts.

Minimal reproduction of the problem with instructions:

N/A

mitchell852 avatar Jul 19 '21 17:07 mitchell852

marked as high impact as i'm guessing these scripts are broken atm.

mitchell852 avatar Nov 30 '21 21:11 mitchell852

Yeah but I've never heard of anyone besides @rob05c using them, and he hasn't complained for at least 5 months. So the impact of this is actually nearly zero.

ocket8888 avatar Nov 30 '21 22:11 ocket8888

well, if you use it the impact to you is high. :)

mitchell852 avatar Nov 30 '21 22:11 mitchell852

frankly I consider those experimental. No part of ATC depends on them, they aren't documented or (clearly) supported.

ocket8888 avatar Nov 30 '21 22:11 ocket8888

I would sadly agree with @ocket8888 - I'm not aware of anyone else using them either.

I don't rebuild from scratch often, but I do use the containers from them frequently.

I've been intending to fix this, just haven't been able to find time.

rob05c avatar Nov 30 '21 23:11 rob05c