Java driver and gremlin server maxContentLength changes for http
Java driver:
- renamed maxContentLength to maxResponseContentLength to clarify that the check is done against the response and not the request
- increased default value to Integer.MAX_VALUE as the size check is now done against the total http response size instead of previous web socket frame size
- changed int to double to allow for higher max value
- changed zero to be an acceptable value which disables the response size check
Gremlin server:
- renamed maxContentLength to maxRequestContentLength to clarify that the check is done against the request and not the response
Feature tests were executed for java driver and pass (other GLV feature tests currently do not work for master-http branch). Manual testing of the changes were done using local gremlin-console with remote connection configured to local gremlin server.
Codecov Report
Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
Please upload report for BASE (
master-http@9797799). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## master-http #2749 +/- ##
==============================================
Coverage ? 77.59%
Complexity ? 13420
==============================================
Files ? 1021
Lines ? 58664
Branches ? 6642
==============================================
Hits ? 45523
Misses ? 10910
Partials ? 2231
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @andreachild, LGTM VOTE +1
VOTE +1
VOTE+1