tinkerpop icon indicating copy to clipboard operation
tinkerpop copied to clipboard

Java driver and gremlin server maxContentLength changes for http

Open andreachild opened this issue 1 year ago • 2 comments

Java driver:

  • renamed maxContentLength to maxResponseContentLength to clarify that the check is done against the response and not the request
  • increased default value to Integer.MAX_VALUE as the size check is now done against the total http response size instead of previous web socket frame size
  • changed int to double to allow for higher max value
  • changed zero to be an acceptable value which disables the response size check

Gremlin server:

  • renamed maxContentLength to maxRequestContentLength to clarify that the check is done against the request and not the response

Feature tests were executed for java driver and pass (other GLV feature tests currently do not work for master-http branch). Manual testing of the changes were done using local gremlin-console with remote connection configured to local gremlin server.

andreachild avatar Aug 28 '24 19:08 andreachild

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-http@9797799). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../org/apache/tinkerpop/gremlin/driver/Settings.java 66.66% 0 Missing and 1 partial :warning:
...he/tinkerpop/gremlin/server/util/GremlinError.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@              Coverage Diff               @@
##             master-http    #2749   +/-   ##
==============================================
  Coverage               ?   77.59%           
  Complexity             ?    13420           
==============================================
  Files                  ?     1021           
  Lines                  ?    58664           
  Branches               ?     6642           
==============================================
  Hits                   ?    45523           
  Misses                 ?    10910           
  Partials               ?     2231           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 28 '24 19:08 codecov-commenter

Thanks @andreachild, LGTM VOTE +1

Cole-Greer avatar Aug 28 '24 21:08 Cole-Greer

VOTE +1

kenhuuu avatar Aug 30 '24 16:08 kenhuuu

VOTE+1

vkagamlyk avatar Aug 30 '24 23:08 vkagamlyk