thrift icon indicating copy to clipboard operation
thrift copied to clipboard

Add support for boringssl

Open layus opened this issue 1 year ago • 3 comments

This adds support for boringssl where OPENSSL_thread_stop is not implemented/defined and CONF_modules_unload is also missing. Fixed by removing these calls when boringssl is in use.

  • [ ] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [ ] Did you squash your changes to a single commit? (not required, but preferred)
  • [X] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [X] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

layus avatar Oct 24 '24 07:10 layus

You'll want to align this to https://github.com/apache/thrift/pull/3049 which I just merged.

jeking3 avatar Oct 24 '24 11:10 jeking3

Indeed. If only it could be made more generic.

BTW, are you sure your patch works as intended? Because by adding your condition to the if branch you fall into the else branch. Might not be what you had in mind.

Le 24 octobre 2024 13:46:31 GMT+02:00, Jim King @.***> a écrit :

You'll want to align this to https://github.com/apache/thrift/pull/3049 which I just merged.

-- Reply to this email directly or view it on GitHub: https://github.com/apache/thrift/pull/3055#issuecomment-2435052905 You are receiving this because you authored the thread.

Message ID: @.***>

layus avatar Oct 24 '24 12:10 layus

@jeking3 Resolved conflicts with https://github.com/apache/thrift/pull/3049, and fixed the logic as per my comment above. May I ask you to have a second look at this PR ?

layus avatar Nov 05 '24 22:11 layus

any movement on this? would be great to have this change in

seanngpack avatar Aug 21 '25 18:08 seanngpack

Still rebase needed

Jens-G avatar Nov 20 '25 22:11 Jens-G

Despite the conflict, there is technically no change when compared against the current master. The equivalent of merge & conflict resolution is an empty diff. So I would consider this done. Feel free to open another PR when I overlooked sth.

Jens-G avatar Dec 02 '25 22:12 Jens-G