Added conditional support in xhr

Open nithinkdb opened this issue 3 years ago • 1 comments

This is a continuation of a pull request that was created a while ago. I've replicated the changes, and added an additional check that keeps functionality largely the same while enabling TBinaryProtocol to be used in XHRRequests. This is needed for functionality in one of our thrift projects. Link to original PR: https://github.com/apache/thrift/pull/2157

[ ] Did you create an Apache Jira ticket? (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit? (not required, but preferred)
[x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Aug 22 '22 20:08 nithinkdb

Hi, any updates on this? Has anyone from the Apache Thrift team taken a look?

Oct 12 '22 19:10 nithinkdb