thrift icon indicating copy to clipboard operation
thrift copied to clipboard

fix reconnect issue for nodejs

Open wujjpp opened this issue 4 years ago • 6 comments

CHANGES:

  1. remove /lib/nodejs/lib/thrift/connection.js#L233-L236, it cause thrift cannot do reconnect
  2. add forceClose variable for indicating close action caseued by manual, and give up reconnecting

wujjpp avatar Jun 11 '21 11:06 wujjpp

Anybody who could doublecheck this patch?

Jens-G avatar Jun 23 '21 18:06 Jens-G

Anybody who could doublecheck this patch?

We have used this patch in production

wujjpp avatar Sep 06 '21 15:09 wujjpp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 17:04 stale[bot]

Generally looks good to me. Could you kindly rebase on latest master and push again?

emmenlau avatar Apr 16 '22 18:04 emmenlau

This issue is no longer stale. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 18:04 stale[bot]

@emmenlau rebased on latest master and pushed

wujjpp avatar May 25 '22 07:05 wujjpp