tajo icon indicating copy to clipboard operation
tajo copied to clipboard

TAJO-1968: Change 'threshold' in the name of configuration and session variables to 'limit'

Open seian opened this issue 9 years ago • 5 comments

seian avatar May 24 '16 17:05 seian

I updated the term threshold to limit but didn't change description on the documentation because it may make users confused.

seian avatar May 24 '16 17:05 seian

Ok. I'll review soon. BTW, you don't have to close and make a new PR to update your patch. When you commit your patch to your repository, github automatically detects the changes and shows them in the existing PR. Actually, this is the strongly encouraged way to update contributors' patch because previous discussions can be kept.

jihoonson avatar May 25 '16 02:05 jihoonson

Thanks for the tip. What should I do if I have to change the whole code in my branch in case of some problems being out there and do code from scratch again? Do I have to do just rollback?

seian avatar May 25 '16 03:05 seian

Yes, it doesn't matter whatever you do using git commands. I think that there is only one exception, that is your local branch is accidentally broken, so you cannot continue your work on that branch.

jihoonson avatar May 25 '16 03:05 jihoonson

Hi @seian, sorry for late review. I left one comment.

jihoonson avatar Jun 14 '16 12:06 jihoonson