systemds icon indicating copy to clipboard operation
systemds copied to clipboard

[SYSTEMDS-2102] Vectorize gradients for Factorization Machines function

Open j143 opened this issue 2 years ago • 5 comments

image

j143 avatar Apr 07 '23 16:04 j143

the code doesn't seem to be correct:

-- old g_V2 -- 0.000 0.000 0.000 -0.001 0.000 -0.000 0.000 -0.002 0.000 0.000 0.000 -0.001 0.000 -0.014

-- g_V2 -- 0.000 -0.017

j143 avatar Apr 07 '23 16:04 j143

LGTM

but remove the commented code.

Baunsgaard avatar Apr 25 '23 13:04 Baunsgaard

Hi @Baunsgaard - thanks for review.

I believe the vectorization I made is incorrect, especially output dimensions. I will keep this in draft for a while.

j143 avatar Apr 25 '23 14:04 j143

Hi @Baunsgaard - thanks for review.

I believe the vectorization I made is incorrect, especially output dimensions. I will keep this in draft for a while.

aww sad, it looked good at a surface glance, maybe we do not have enough tests ? or is it that the NN is only in the Application tests again.

Baunsgaard avatar Apr 25 '23 19:04 Baunsgaard

We verify the with gradients at the moment. but, we need to verify against R implementation once.

j143 avatar Apr 29 '23 03:04 j143