systemds icon indicating copy to clipboard operation
systemds copied to clipboard
verified publisher icon apache

[SYSTEMDS-3272] setSchema built-in to set the schema of frame from DML

Open Shafaq-Siddiqi opened this issue 4 years ago • 4 comments

  • This built-in will allow changing the schema of a frame inside DML
  • Function call is placed inside detectSchema test

Shafaq-Siddiqi avatar Jan 12 '22 17:01 Shafaq-Siddiqi

Thanks for this extension @Shafaq-Siddiqi. This crashes because FP32 and INT32 are missing in the exact serialized size calculation logic (FrameBlock.java::getExactSerializedSize()). I will investigate it further.

phaniarnab avatar Jan 13 '22 20:01 phaniarnab

Thanks for this extension @Shafaq-Siddiqi. This crashes because FP32 and INT32 are missing in the exact serialized size calculation logic (FrameBlock.java::getExactSerializedSize()). I will investigate it further.

This sounds related to the Bug just fixed in de3b9703d689d7877ccd8c7746ba10e42941fafa

Baunsgaard avatar Aug 25 '22 18:08 Baunsgaard

Is this PR no longer relevant?

Baunsgaard avatar Aug 25 '22 18:08 Baunsgaard

Nope. It is a duplicate. Safe to close.

phaniarnab avatar Aug 25 '22 18:08 phaniarnab