synapse icon indicating copy to clipboard operation
synapse copied to clipboard
verified publisher icon apache

Update FaultHandler.java duplicate log entry. this is already availal…

Open sadhiq1983 opened this issue 4 months ago • 4 comments

…e when tracerOrDebugOn is enabled

This changes is intended to remove duplicate log entry.

  • This is already available when tracerOrDebugOn flag is enabled.
  • This entry flooding the logs files whenever this handler gets involved. for eg: "FaultHandler executing impl: "

Purpose

log enhancement. It improves the logging. This is simply adding entry to log file whenever fault handler is executed. Since we already taken care with flag tracerOrDebugOn , we can remove this duplicate entry.

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI. Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

Release note

If applicable a brief description of the new feature or bug fix as it will appear in the release notes

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Related PRs

List any other related PRs

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

sadhiq1983 avatar Sep 18 '25 10:09 sadhiq1983

Team,

Please review the PR and provide your valuable comments. Thanks.

sadhiq1983 avatar Sep 18 '25 10:09 sadhiq1983

Can you please point out the place where this log entry is duplicated?

isudana avatar Oct 08 '25 17:10 isudana

Can you please point out the place where this log entry is duplicated?

Thank you @isudana for checking on this pull request. In this file , if you see the line number 48, 49 we are printing this statement based on the flag "traceOrDebugOn". And again we are printing the same message on line number 53.

sadhiq1983 avatar Nov 05 '25 06:11 sadhiq1983

Can you please point out the place where this log entry is duplicated?

Thank you @isudana for checking on this pull request. In this file , if you see the line number 48, 49 we are printing this statement based on the flag "traceOrDebugOn". And again we are printing the same message on line number 53.

Due to this we had an customer issue raising logs were getting piled up and they were unable to stop this statement. hence this fix was suggested. @isudana

sadhiq1983 avatar Nov 14 '25 10:11 sadhiq1983