superset icon indicating copy to clipboard operation
superset copied to clipboard

[SIP-134] Hide inactive users

Open lyndsiWilliams opened this issue 1 year ago • 3 comments

[SIP-134] Proposal for Hide inactive users

Motivation

Some users don't want/need to see inactive users in the "Owners" dropdown in list views and on Superset entities.

Proposed Change

Use the isActive attribute to hide any users that are inactive on the front end. We can put this behind a config flag since some users do want to see inactive users.

New or Changed Public Interfaces

  • Any instances of the "Owners" dropdown will only show active users.
  • This will be toggled with a config flag so that users have the option to show or hide inactive users.

New dependencies

None.

Migration Plan and Compatibility

No changes here.

Rejected Alternatives

I'm unaware of any rejected alternatives.

lyndsiWilliams avatar May 18 '24 03:05 lyndsiWilliams

What determines whether a user is active or inactive? Are there thresholds to be set as well?

Is it better to flag users as "inactive" rather than "isActive" assuming they're active by default, and may fall into some lapsed state? This may avoid having to run a migration to add "isActive" to all users.

rusackas avatar Jun 04 '24 15:06 rusackas

@lyndsiWilliams maybe this isn't a temporal thing, but just based on a flag on the user account that already exists? In an y case, would you mind putting this up for a [DISCUSS] thread if you want to move the ball forward?

rusackas avatar Jun 18 '24 15:06 rusackas

My guess is that it would use the is Active checkbox on the List Users page, is that what you were thinking @lyndsiWilliams ?

yousoph avatar Jun 18 '24 19:06 yousoph

@lyndsiWilliams just wondering if there's any intent to follow through with this.

rusackas avatar Aug 28 '24 16:08 rusackas

Just a heads up, this'll be closed as inactive on October 17th unless there's any follow-up/backing to move it through the process. Thanks!

rusackas avatar Sep 10 '24 16:09 rusackas

Closing as discarded

rusackas avatar Nov 06 '24 17:11 rusackas