chore(models): Adding encrypted field checks
SUMMARY
It was recently discovered that the SSHTunnel model class was using the EncryptedField type decorator directly as opposed to leveraging the EncryptedFieldFactory. Although the current impl would allow for the proper encryption of fields in the SSHTunnel model, anyone that's implemented a custom field via EncryptedFieldFactory.create() would have been broken as of the addition of SSHTunnel
- Fixes
SSHTunnel - Adds additional unit test that verifies all
EncryptedTypefields were created viaEncryptedFieldFactory.create()
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.39%. Comparing base (
76d897e) to head (b58d5d3). Report is 87 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #28436 +/- ##
===========================================
+ Coverage 60.48% 83.39% +22.90%
===========================================
Files 1931 521 -1410
Lines 76236 37408 -38828
Branches 8568 0 -8568
===========================================
- Hits 46114 31195 -14919
+ Misses 28017 6213 -21804
+ Partials 2105 0 -2105
| Flag | Coverage Δ | |
|---|---|---|
| hive | 49.03% <91.66%> (-0.13%) |
:arrow_down: |
| javascript | ? |
|
| mysql | 77.10% <100.00%> (?) |
|
| postgres | 77.21% <100.00%> (?) |
|
| presto | 53.60% <91.66%> (-0.21%) |
:arrow_down: |
| python | 83.39% <100.00%> (+19.90%) |
:arrow_up: |
| sqlite | 76.66% <100.00%> (?) |
|
| unit | 58.76% <91.66%> (+1.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.