superset icon indicating copy to clipboard operation
superset copied to clipboard
Published 1 month ago • verified publisher icon apache

chore(superset-ui-core): Migrate FallbackComponent.test to RTL

Open rtexelm opened this issue 1 year ago • 1 comments

SUMMARY

Simple changes to utilize RTL instead of enzyme

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

rtexelm avatar May 06 '24 16:05 rtexelm

@eschutho thanks for reminding me, forgot in my haste to get a PR up. this is what you're thinking of, right?

rtexelm avatar May 06 '24 22:05 rtexelm

@rtexelm yeah, that's perfect!

eschutho avatar May 07 '24 23:05 eschutho