Unable to save report due to Add button not enable

[badf007]

Bug description

While filling in all the required information there is still an error in the Notification method section where it shows that a recipient is missing even when valid emails are provided.

How to reproduce the bug

1. Go to alerts and reports.
2. Go to the report section
3. Click Add report
4. Fill all required fields.

What should happen:

• The ADD button is enabled and the report can be saved

What is happening:

• The ADD button is not enabled and a red asterisk is shown in the EMAIL RECIPIENTS field.

Screenshots/recordings

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

• [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
• [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
• [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

[cmartinezdnn]

Same issue happening to me. It looks like there is bug in new superset 4.0 version.

[sfirke]

Someone in Slack is seeing this too. I am running 4.0.0 in production and can successfully create a new alert, so this is not universally broken. My best guess is that there's something in the recipients validation checker that succeeds on my instance but fails for these people without telling them why. CC @fisjac as I believe they wrote some of this new validation.

[alexkyurtev]

please contact me if further information is needed , i`m also seeing this bug on my side

[fisjac]

Looking into this.

[padbk]

I am also seeing this issue, it is preventing our upgrade to 4.0.0 and is it not fixed in 4.0.1rc1

@michael-s-molina Could you help to get the above PR merged and included in 4.0.1 please? 🙏

[square-li]

+1 also having this issue with 4.0. Thanks!

[rusackas]

4.0.1 has been voted in... so this could become part of 4.0.2, coming soon. If you want to test/vote on these release candidates officially, please do join the [email protected] email list (let me know if you want instructions).

Normally we close issues with the PR that fixes them is merged to master. If that's the case here, we should close this, and the fix will be destined for the next release. Any objections?

[adimyth]

@rusackas I checked the release-announcements channel & other relevant channels on slack, but couldn't find a tentative timeline for 4.0.2 release

Any idea when would it be released?

PS - @fisjac thanks for fixing this 👍

[michael-s-molina]

Hi @adimyth. We generally try to release a patch every month. We just released 4.0.1 on Monday so 4.0.2 will probably be released mid June. @eschutho @sadpandajoe are working on 4.1 but I don't know if it will be released sooner.

[sfirke]

Alright folks watching this issue: Superset 4.0.2 is up for a vote! Anyone is welcome to test out the release and vote on it. Test it by deploying the docker image: apache/superset/4.0.2rc1 or apache/superset/4.0.2rc1-dev.

Vote by subscribing to the public email list https://lists.apache.org/[email protected] and replying to the email Michael sent this morning! Please test that this bug is fixed and that everything else works as it should. I am going to copy-paste this message onto a couple of other issues for visibility, sorry to folks who get multiple messages.

[giacomochiarella]

Hi everyone! 4.0.2 is under voting. I went through the changelog here and I cannot see any reference to this or this. Moreover this is still open. Anybody can give some clearance on this bug? I would down vote if this is not resolved actually (it is a regression, it was working in 4.0.0 and stopped in 4.0.1)

[michael-s-molina]

Fixed by https://github.com/apache/superset/pull/28409