superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(filter_state): Added @api and @has_access_api to all methods of filter_state API.

Open xneg opened this issue 2 years ago • 1 comments

SUMMARY

The API of filter_state is already exposed but it doesn't look like other APIs. We had a problem gaining 403 Status Code when addressing this endpoint. It was because of the lack of role permissions but there were no messages in the logs. Introducing these decorators we add recording the problem to the log so it will be easier to investigate the problem.

Comment

This is a copy of https://github.com/apache/superset/pull/23282 because I've lost access to the company's repository and they are not working intensively on Superset now.

xneg avatar Feb 12 '24 16:02 xneg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6c5e8fa) 67.21% compared to head (3404bcf) 69.54%. Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27086      +/-   ##
==========================================
+ Coverage   67.21%   69.54%   +2.32%     
==========================================
  Files        1899     1899              
  Lines       74395    74401       +6     
  Branches     8278     8278              
==========================================
+ Hits        50006    51742    +1736     
+ Misses      22334    20604    -1730     
  Partials     2055     2055              
Flag Coverage Δ
hive 53.82% <100.00%> (?)
mysql 78.04% <100.00%> (+<0.01%) :arrow_up:
postgres 78.14% <100.00%> (+<0.01%) :arrow_up:
presto 53.77% <100.00%> (?)
python 83.10% <100.00%> (+4.82%) :arrow_up:
sqlite 77.66% <100.00%> (+<0.01%) :arrow_up:
unit 56.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 16:02 codecov[bot]