superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(dashboard): Fix hover labels for horizontal overflow native filter dividers

Open codyml opened this issue 3 years ago • 1 comments

SUMMARY

This PR is based on #22169 and fixes hover labels that weren't appearing for dividers in horizontal native filters overflow dropdown.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Screen Shot 2022-11-23 at 3 08 58 PM

After: Screen Shot 2022-11-23 at 3 08 30 PM Screen Shot 2022-11-23 at 3 08 41 PM

TESTING INSTRUCTIONS

  • Ensure that dividers in the horizontal overflow dropdown show tooltips for titles and descriptions that are truncated.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [x] Required feature flags: HORIZONTAL_FILTER_BAR
  • [x] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

codyml avatar Nov 23 '22 22:11 codyml

Codecov Report

Merging #22210 (a7ec2d2) into master (64939f2) will decrease coverage by 0.01%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #22210      +/-   ##
==========================================
- Coverage   66.91%   66.90%   -0.02%     
==========================================
  Files        1839     1839              
  Lines       70079    70084       +5     
  Branches     7636     7638       +2     
==========================================
- Hits        46894    46890       -4     
- Misses      21218    21220       +2     
- Partials     1967     1974       +7     
Flag Coverage Δ
javascript 53.74% <66.66%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/hooks/useTruncation/useCSSTextTruncation.ts 69.23% <55.55%> (-30.77%) :arrow_down:
...Filters/FilterBar/FilterControls/FilterDivider.tsx 81.48% <100.00%> (-18.52%) :arrow_down:
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 25 '22 12:11 codecov[bot]