[WIP] feat(dashboard): Add fallback support for right-clicking on unsupported viz plugins

[codyml]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• [ ] Has associated issue:
• [ ] Required feature flags:
• [ ] Changes UI
• [ ] Includes DB Migration (follow approval process in SIP-59)
  • [ ] Migration is atomic, supports rollback & is backwards-compatible
  • [ ] Confirm DB migration upgrade and downgrade tested
  • [ ] Runtime estimates and downtime expectations provided
• [ ] Introduces new feature or API
• [ ] Removes existing feature or API

[codecov[bot]]

Codecov Report

Merging #21351 (a422706) into master (200bed6) will decrease coverage by 0.02%. The diff coverage is 53.93%.

:exclamation: Current head a422706 differs from pull request most recent head 7d4f844. Consider uploading reports for the commit 7d4f844 to get more accurate results

@@            Coverage Diff             @@
##           master   #21351      +/-   ##
==========================================
- Coverage   66.84%   66.81%   -0.03%     
==========================================
  Files        1799     1800       +1     
  Lines       68902    68943      +41     
  Branches     7324     7337      +13     
==========================================
+ Hits        46057    46067      +10     
- Misses      20955    20985      +30     
- Partials     1890     1891       +1     

Flag	Coverage Δ
javascript	53.16% <53.93%> (+<0.01%)	:arrow_up:
mysql	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../packages/superset-ui-core/src/chart/types/Base.ts	100.00% <ø> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js	0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-world-map/src/index.js	66.66% <ø> (ø)
...hart-echarts/src/BigNumber/BigNumberTotal/index.ts	66.66% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx	0.00% <0.00%> (ø)
...arts/src/BigNumber/BigNumberWithTrendline/index.ts	66.66% <ø> (ø)
.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts	50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts	50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts	50.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx	0.00% <0.00%> (ø)
... and 40 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

Thanks for the awesome PR description @codyml. I have a suggestion while looking at the screenshots. Can we standardize the way we display messages?

For example:

I like disabling the option and showing an icon with a tooltip. Can we do the same for the "Drill to detail by" option? As you can see in the screenshot below, the message is displayed as a sub-item and the text is greyed out which is hard to read. It also forces the user to open the sub-menu before realizing the operation is not supported. I think using the icon plus tooltip also helps when the user already knows the possible causes and just wants to see if the option is enabled or not.

[codyml]

Thanks for the awesome PR description @codyml. I have a suggestion while looking at the screenshots. Can we standardize the way we display messages?

@michael-s-molina that works for me! @kasiazjc any thoughts?

[kasiazjc]

@michael-s-molina that works for me! @kasiazjc any thoughts?

Awesome work, thanks @codyml ❤️

I think @michael-s-molina 's suggestion makes sense! let's go for it. Thanks for feedback Michael 🙏

[geido]

/testenv up FEATURE_DRILL_TO_DETAIL=true

[github-actions[bot]]

@geido Ephemeral environment spinning up at http://35.162.90.188:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

/testenv up FEATURE_DRILL_TO_DETAIL=true

[github-actions[bot]]

@geido Ephemeral environment spinning up at http://54.191.69.132:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

Two nits and a question from manual testing:

• Probably not related to this PR but it looks weird that in the Modal there are two loading icons for both the table content and the Metadatabar cc @kasiazjc

https://user-images.githubusercontent.com/60598000/194037386-8b882c9e-7fa6-4a75-acd2-82e021501398.mp4

• It is possible to rightclick on a chart when the Modal is open. We should probably disable this possibility as the click isn't behaving correctly anyway

https://user-images.githubusercontent.com/60598000/194038602-96e2ef04-2f63-46bb-85f6-5d844d1abd6d.mp4

• I thought we were supporting the Big number with trendline viz type but it shows that the Drill to detail by is disabled, is that right?

[codyml]

@michael-s-molina that works for me! @kasiazjc any thoughts?

Awesome work, thanks @codyml ❤️

I think @michael-s-molina 's suggestion makes sense! let's go for it. Thanks for feedback Michael 🙏

@michael-s-molina @kasiazjc Done! Updated videos in PR description.

[codyml]

Two nits and a question from manual testing:

• Probably not related to this PR but it looks weird that in the Modal there are two loading icons for both the table content and the Metadatabar cc @kasiazjc

Video.Game.Sales.mp4

Agreed, will look into separately.

• It is possible to rightclick on a chart when the Modal is open. We should probably disable this possibility as the click isn't behaving correctly anyway

Video.Game.Sales.1.mp4

Fixed.

• I thought we were supporting the Big number with trendline viz type but it shows that the Drill to detail by is disabled, is that right?

Oops, turns out I forgot to add the Behaviors.DRILL_TO_DETAIL behavior to Big Number, Big Number w/ Trendline, Graph and Treemap v2, so they were all giving that error. Should be fixed now.

[geido]

/testenv up FEATURE_DRILL_TO_DETAIL=true

[michael-s-molina]

@codyml Thanks for addressing all suggestions. I think after applying @zhaoyongjie suggestions we'll be in a good shape to involve QA as the final step before merging it. Thanks for all the hard work!

[jinghua-qa]

/testenv up FEATURE_DRILL_TO_DETAIL=true

[github-actions[bot]]

@jinghua-qa Ephemeral environment spinning up at http://35.88.162.144:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions[bot]]

Ephemeral environment shutdown and build artifacts deleted.