superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: quick fix to rows returned in results

Open AAfghahi opened this issue 3 years ago • 2 comments

SUMMARY

At some point the styling that was created for limit messages was changed. This changes it back.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-08-05 at 4 14 32 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

AAfghahi avatar Aug 05 '22 20:08 AAfghahi

Codecov Report

Merging #20999 (cab1293) into master (9350bba) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20999      +/-   ##
==========================================
- Coverage   66.34%   66.34%   -0.01%     
==========================================
  Files        1767     1767              
  Lines       67287    67290       +3     
  Branches     7142     7142              
==========================================
- Hits        44643    44641       -2     
- Misses      20816    20821       +5     
  Partials     1828     1828              
Flag Coverage Δ
hive 53.13% <ø> (ø)
javascript 52.11% <100.00%> (+<0.01%) :arrow_up:
mysql 80.92% <ø> (ø)
postgres 80.99% <ø> (ø)
presto 53.03% <ø> (ø)
python 81.46% <ø> (-0.02%) :arrow_down:
sqlite 79.58% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 51.70% <100.00%> (+1.00%) :arrow_up:
superset/initialization/__init__.py 89.96% <0.00%> (-1.74%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Aug 05 '22 20:08 codecov[bot]

lgtm!

pkdotson avatar Aug 05 '22 20:08 pkdotson