superset icon indicating copy to clipboard operation
superset copied to clipboard

Connect database from top right corner button doesn't work in 1.5.1

Open mayurnewase opened this issue 3 years ago • 0 comments

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to homepage
  2. Hover on + sign on top right corner -> hover on data -> click "Connect database"

It works in master, happening because Antd tab component in this version is calling onclick handler with key of the parent element instead of the actual element being clicked so onclick handler doesn't recognise the key and ignores the event.

Expected results

Should open Add database modal

Actual results

Nothing happens

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

(please complete the following information):

  • browser type and version:
  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [x] I have reproduced the issue with at least the latest released version of superset.
  • [x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

mayurnewase avatar Aug 03 '22 02:08 mayurnewase