superset icon indicating copy to clipboard operation
superset copied to clipboard

feat(api): specify query parameters for the embedded chart or dashboard

Open panesofglass opened this issue 3 years ago • 5 comments

SUMMARY

Add support for specifying query parameters to append to embedded charts or dashboards.

Motivation: we are trying to embed parameterized dashboards and would like to specify the parameters in the embedDashboard object.

TESTING INSTRUCTIONS

I couldn't find existing tests. We've tested the general approach by adding the parameters to the end of the iframe.src, and it seems to work. I'd be happy to add tests if I can find out where to add them.

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

panesofglass avatar Jun 03 '22 21:06 panesofglass

What's the status of this PR? I'm interested in this feature

brandonlockhart avatar Aug 04 '22 16:08 brandonlockhart

Thanks for the PR I need this feature to disable expand filters in the dashboard. Any ETA for this feature?

VinayGoudCheguri avatar Oct 10 '22 07:10 VinayGoudCheguri

May I know the ETA for this feature?

VinayGoudCheguri avatar Apr 05 '23 12:04 VinayGoudCheguri

This PR seems to be stale (is in a conflicted state + review comment hasn't been responded to), but there is another one that should cover this use case: #23344 Does this PR address your needs @VinayGoudCheguri ? Please chime in on that PR.

villebro avatar Apr 05 '23 14:04 villebro

Since this thread seems to have gone silent, I'll just close this in favor of https://github.com/apache/superset/pull/23344

Please feel free to re-open if you want to get this across the finish line. Thanks for the contribution!

rusackas avatar Feb 09 '24 20:02 rusackas