superset icon indicating copy to clipboard operation
superset copied to clipboard

Annotation Layer Text Display Overlapping with Graph Legends

Open pseudoPixels opened this issue 4 years ago • 8 comments

Screenshot

Screen Shot 2021-10-14 at 10 29 29 AM

When hovered on any Annotation Layer (it overlaps): Screen Shot 2021-10-14 at 10 29 06 AM

Description

On addition of Event Annotation Layer to the charts the Annotation Layer text (on hover) often overlaps with chart legends. Specially when a chart contains many legends (like in the above images), there are not enough space for the Annotation text to display. The display overlap makes it hard to read both (Legend and Annotation) of the texts.

Design input

It would be great to see the Annotation Hover text to be adaptive; that is to position itself to the nearest empty space available.

If making it adaptive is not too easy, we can have one setting in the Annotation Modal to specify the positioning like at Top, Middle, Bottom etc.

design:review design:suggest

pseudoPixels avatar Oct 15 '21 17:10 pseudoPixels

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

stale[bot] avatar Apr 17 '22 17:04 stale[bot]

@pseudoPixels this issue seems a bit old, and there have been numerous chart changes and annotation layer fixes since then. Can you confirm whether or not this issue is still present in 2.0.x? If so, it would also help to know your chart and annotation layer configurations so we can more easily reproduce the issue. Thanks!

rusackas avatar Jan 18 '23 15:01 rusackas

is this still present?

rajveer43 avatar Jul 29 '23 12:07 rajveer43

is it still open to work?

rajveer43 avatar Aug 18 '23 10:08 rajveer43

@rajveer43 are you saying you're still experiencing this bug in a recent version (2.1.0 or latest) and want to try to fix it? That would be great!

sfirke avatar Aug 18 '23 13:08 sfirke

please assign this issue as a new contributor, it is looking good for me

thedeeppp avatar Nov 11 '23 07:11 thedeeppp

please assign this issue as a new contributor, it is looking good for me

Done! Thanks for working on this. If you have questions please consult the contributing.md file and ask in Slack chat if it's unclear after that.

sfirke avatar Nov 11 '23 14:11 sfirke

@thedeeppp have you made any progress on this? Or can you confirm that it's still an issue in Superset 3.1? If not, this issue is at risk of being closed as stale.

rusackas avatar Apr 04 '24 18:04 rusackas

May I work on this issue with a little bit of your guidance?

laksh-krishna-sharma avatar Jul 30 '24 13:07 laksh-krishna-sharma

I want to work on this issue, looks a good bug to catch. I see it's pending since long ago. Thanks !! :):)

nitesh-dubey-samsung avatar Sep 16 '24 09:09 nitesh-dubey-samsung

is it still open or this issue has been fixed. It is open long time ago. @sfirke

Abdullah-Alamodi avatar Sep 19 '24 07:09 Abdullah-Alamodi

I don't know if this issue persists. Do you experience it @Abdullah-Alamodi ? If people are looking for ways to contribute to Superset there are probably better first issues than this.

It would be nice if someone can verify whether this is still a problem in 4.0.2.

sfirke avatar Sep 19 '24 11:09 sfirke

I can triage the issue and if it's still there I can fix it up :)

farhaanbukhsh avatar Nov 13 '24 10:11 farhaanbukhsh

Thank you for reporting this issue. However, the issue was reported on a version of Superset that we no longer support or it does not contain a valid Superset version. As of this moment, we only actively support Superset 4.0 and 4.1. To maintain a more actionable Issues backlog, we're going to close this issue for now. If you (or anyone reading this) are still experiencing this on a currently supported version of Superset, please either reopen this Issue, or file a new one with updated context (screenshots, reproduction steps) and we'll do our best to support it. Thank you

michael-s-molina avatar Jan 23 '25 19:01 michael-s-molina