superset icon indicating copy to clipboard operation
superset copied to clipboard

[metric]Rename column name with non-english string

Open heartcored98 opened this issue 4 years ago • 5 comments

Is your feature request related to a problem? Please describe.

Hi, I am really enjoying superset, but I am frustrated when I have to rename column with non-english string. Because if I try to change the column name in Korean (for example metrics column), then generated sql query contains Korean with AS statement. Therefore, BigQuery engine is broken.

Describe the solution you'd like I would like to manually assign column names of group by and metrics with any-language string, through the chart explore ui.

Since bigquery column name rule does not allows non-english character, I think a field name variable should be prepared separately from the column name in SQL query.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Following images is error message when I assign '날짜' string to one of the metrics column.

image

image

heartcored98 avatar Aug 06 '21 05:08 heartcored98

we will consider this issue in metric refactor project. cc: @junlincc

zhaoyongjie avatar Aug 06 '21 07:08 zhaoyongjie

@heartcored98 we will start the metrics redesign/refactoring in later Q3 to include more column customization.

junlincc avatar Aug 06 '21 16:08 junlincc

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

stale[bot] avatar Apr 30 '22 08:04 stale[bot]

Are there any updates on the issue? This issue is very annoying when using Superset with BigQuery.

zertyuiop avatar Sep 09 '22 16:09 zertyuiop

Same issue: https://github.com/apache/superset/issues/3136

zertyuiop avatar Nov 19 '22 16:11 zertyuiop

Closing in favor of https://github.com/apache/superset/issues/21658 - please take the discussion there.

rusackas avatar Feb 13 '24 21:02 rusackas