apache
[sql_lab]Add back description column to saved queries
Is your feature request related to a problem? Please describe. The description column was removed from the saved queries. We would like to add it back. Styling TBD
Describe the solution you'd like Show the description of the saved query if it exists on the saved queries page.
Describe alternatives you've considered Not showing the description, but it seems helpful.
Additional context
@eschutho @yousoph yes! ill make a design ticket for this and coordinate w Sophie
Let's add the column as the second column from the left (right after name)
@khallon would love to be pinged when a PR is ready to take a look and give potential design feedback/tweaks :) Thanks!
@rusackas I've never contributed to OSS. I would like to take a stab at this one if nobody is actively working on it.
@imancrsrk go for it! In your eventual PR description, just add "Fixes #12431" to auto-close this issue upon merge. :)
@rusackas I've raised PR - https://github.com/apache/superset/pull/28349. I see that 2 checks have passed but another 18 are waiting to be reported, hope this is ok. Hope to get a review soon!
Thanks :-)
Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views that may or may not be warranted.
Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views that may or may not be warranted.
I replied back. The search filter is already searching all text columns, name, description, etc. so @nytai suggested that we make the filter name more general, search
@rusackas I've added the tooltip description. https://github.com/apache/superset/pull/28349#discussion_r1591651467
@rusackas I had sent out a change that aligns the tooltip better. Hope you can take a look at it today and let me know if anything else is needed :-)